[mlir][dxsa] Add dcl_tgsm_raw instruction#138
Merged
Conversation
asavonic
approved these changes
May 26, 2026
| (`,` `index` `=` $index^)? | ||
| `>` | ||
| }]; | ||
| let assemblyFormat = "`<` struct(params) `>`"; |
Contributor
There was a problem hiding this comment.
That's nice, we need to use this shortcut for other instructions as well.
| def DXSA_DclTgsmRaw : DXSA_Op<"dcl_tgsm_raw"> { | ||
| let summary = "declares a reference to a region of shared memory space"; | ||
| let description = [{ | ||
| The `dxsa.dcl_tgsm_raw` operation declares a reference to a region |
Contributor
There was a problem hiding this comment.
Suggested change
| The `dxsa.dcl_tgsm_raw` operation declares a reference to a region | |
| The `dxsa.dcl_tgsm_raw` operation declares a reference to a Thread Group Shared Memory region. |
Can we deabbreviate TGSM here?
Author
There was a problem hiding this comment.
Current description of the operation is a copy of the original description from the spec:
22.3.45 dcl_tgsm_raw (Raw Thread Group Shared Memory (g#) Declaration)
Description: Declare a reference to a region of shared
memory space available to the Compute
Shader’s thread group.
Contributor
There was a problem hiding this comment.
Right, but the spec deabbreviates TGSM in the title, and here we need to look at the example to find out what it means.
tagolog
force-pushed
the
dxsa-mlir-dcl_tgsm_raw
branch
from
64a63c0 to
3a3f113
Compare
Example: dxsa.dcl_tgsm_raw <type = thread_group_shared_memory, components = 0, index = [0]>, 40 Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
tagolog
force-pushed
the
dxsa-mlir-dcl_tgsm_raw
branch
from
3a3f113 to
0654b0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.dcl_tgsm_raw <type = thread_group_shared_memory, components = 0, index = [0]>, 40